Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frameworks table so it's alphabetical #13118

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Conversation

osanseviero
Copy link
Member

What does this PR do?

This is a minor PR to make the frameworks table alphabetical

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LysandreJik
Copy link
Member

Thanks for the PR! Could you run make fix-copies to fix the code quality issue?

@osanseviero
Copy link
Member Author

Thanks, I didn't realize there was a script to automatically generate the table. I changed the sort call so there is no difference between uppercase and lowercase, hence removing lowercase models from the end of the list. This creates few other diffs, so please let me know if this is ok.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM!

@osanseviero osanseviero merged commit c066598 into master Aug 16, 2021
@osanseviero osanseviero deleted the fix-models-table branch August 16, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants