Fixing big endian. #327
Merged
Fixing big endian. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Many more tests, with numpy coverage. - Actually test values on disk.
|
The documentation is not available anymore as the PR was closed or merged. |
McPatate
reviewed
Aug 17, 2023
Comment on lines
+117
to
+118
| cache-from: type=registry,ref=registry.internal.huggingface.tech/safetensors/s390x:cache,mode=min | ||
| cache-to: type=registry,ref=registry.internal.huggingface.tech/safetensors/s390x:cache,mode=min |
There was a problem hiding this comment.
Curious to hear what the motivation behind this change was
There was a problem hiding this comment.
The tests were failing, deleting cache made them work again. I therefore modified this and deleted the cache again. Didn't look too hard into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #321
Fixes # (issue) or description of the problem this PR solves.