Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustls-tls-native-roots to allow for OS cert stores for rustls #77

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FileMagic
Copy link

following the discussion in #36 (comment) I realized we can use the rustls-tls-native-roots which says: "Enables TLS functionality provided by rustls, while using root certificates from the rustls-native-certs crate."

The rustls-native-certs "Integration with OS certificate stores for rustls." So it should allow for you to use the root certs from your host. Which should fix our issue from issue #36.

@McPatate
Copy link
Member

Lgtm, could you update llm-ls' version in its Cargo.toml to 0.5.2?

@FileMagic
Copy link
Author

FileMagic commented Feb 13, 2024

I also need to test this, but I did pull down your changes.

@FileMagic
Copy link
Author

@McPatate just to make sure I did this correctly I saw ya'll were using xtask so I ran a cargo xtask dist. I then set the llm.lsp.binaryPath to be <path_to_llm_ls_repo>/target/debug/llm-ls in vscode to be the bin I compiled. Then tried an cert I generated for an proxy I made that used a self generated tls cert trusted by the host.

This is all different than what is stated here.

So I wanted to make sure that this was fine. However, everything seemed to work.

@McPatate
Copy link
Member

cargo xtask dist is used to build llm-ls to be bundled with the vscode extension. I'm not even sure why it worked, I thought it build in release mode only 🤔

Either way, if it works for you this is the same as running cargo build [-r]

@FileMagic
Copy link
Author

FileMagic commented Mar 8, 2024

Well I see that I made a mistake 3 weeks ago when I was writing this comment. it was not debug it was release. However, yeah this seemed to work for me as a fix for the self signed tls certs. I apologize for the delay.

@FileMagic
Copy link
Author

Let me know if there is anything else needed for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants