Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit 1 notebook small writing improvements #62

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

DennisSoemers
Copy link
Contributor

This PR just includes a few (really minor) writing improvements in the notebook for Unit 1.

Note: the most impactful change is probably that I suggest to remove this (line 529):

"- The game is solved if your agent does 200 points."

Unless I missed it, the rest of the course (at least so far, so just with Unit 1) does not get into details anywhere on the idea of "solving" when passing a certain threshold in gym environments. It's also really uniquely a gym thing though, and not a concept that applies anywhere across the rest of RL, so in my opinion it's better to not mention it at all.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@simoninithomas
Copy link
Member

simoninithomas commented Jul 14, 2022

Hi Dennis.

Thanks for the updates. I'm merging it. I'm currently updating each of the colab so your feedback is very useful 🤗 . I merge it.

I'm agree with the line update ""- The game is solved if your agent does 200 points."" I think I will replace with: for this exercise try to reach ~200 mean_reward.

@simoninithomas simoninithomas merged commit 3579809 into huggingface:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants