Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI require beam #5168

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

albertvillanova
Copy link
Member

This PR:

  • Fixes the CI require_beam: before it was requiring PyTorch instead
    def require_beam(test_case):
        if not config.TORCH_AVAILABLE:
            test_case = unittest.skip("test requires PyTorch")(test_case)
        return test_case
  • Fixes a missing require_beam in test_beam_based_builder_download_and_prepare_as_parquet
  • Refactors require_beam to use pytest (skipif) instead

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 26, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova
Copy link
Member Author

I'm merging this PR because it is quite a trivial fix and this is required by:

@albertvillanova albertvillanova merged commit 11f1fde into huggingface:main Oct 27, 2022
@albertvillanova albertvillanova deleted the fix-require-beam branch October 27, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants