Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate num_proc parameter in DownloadManager.extract #5142

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Deprecate num_proc parameter in DownloadManager.extract #5142

merged 5 commits into from
Oct 25, 2022

Conversation

ayushthe1
Copy link
Contributor

fixes #5132 : Deprecated the num_proc parameter in DownloadManager.extract by passing num_proc parameter to map_nested .

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

mariosasko
mariosasko reviewed Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/datasets/download/download_manager.py Outdated Show resolved Hide resolved
@ayushthe1
Copy link
Contributor Author

Hey @mariosasko . Can you please help me with why the tests keep failing. I have reviewed the code changes multiple times but can't spot any mistakes.

@mariosasko
Copy link
Collaborator

You can fix this failure by formatting your code with the make style command (run it from the root of the cloned repo).

@ayushthe1
Copy link
Contributor Author

hey @mariosasko ,i cant understand how to use the make style command .I searched for it on the internet but cant find any results.
So i formatted the code using vs-code document formatter. Hope this helps.

mariosasko
mariosasko approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariosasko
Copy link
Collaborator

mariosasko commented Oct 24, 2022 •
edited
Loading

make style runs the "style" target defined here:

datasets/Makefile

Line 12 in f09f781

style:

This seems to be a good tutorial on Makefiles: https://opensource.com/article/18/8/what-how-makefile

lhoestq
lhoestq approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@mariosasko mariosasko merged commit d12fbc1 into huggingface:main Oct 25, 2022
@ayushthe1
Copy link
Contributor Author

make style runs the "style" target defined here:

datasets/Makefile

Line 12 in f09f781

style:

This seems to be a good tutorial on Makefiles: https://opensource.com/article/18/8/what-how-makefile

Thanks! I will look into this ☺️

@mariosasko mariosasko mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariosasko mariosasko mariosasko approved these changes

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depracate num_proc parameter in DownloadManager.extract
4 participants
@ayushthe1 @HuggingFaceDocBuilderDev @mariosasko @lhoestq