Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filename matching more robust #5128

Merged

Conversation

riccardobucco
Copy link
Contributor

Fix #5046

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 18, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we should also modify one of the metadata files in the folder_based_builder tests to make sure "./" is ignored now in the file_name

@riccardobucco
Copy link
Contributor Author

I think we should also modify one of the metadata files in the folder_based_builder tests to make sure "./" is ignored now in the file_name

@mariosasko what do you mean here? I'm not sure which metadata file I should modify here

@mariosasko
Copy link
Collaborator

You can modify this line for instance:

{"file_name": "subdir/file3.txt", "additional_feature": "Third dummy file"}

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks all good now!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM :)

@mariosasko mariosasko merged commit f2831a4 into huggingface:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audiofolder creates empty Dataset if files same level as metadata
4 participants