Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tutorial (#5093) #5095

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix tutorial (#5093) #5095

merged 1 commit into from
Oct 10, 2022

Conversation

riccardobucco
Copy link
Contributor

@riccardobucco riccardobucco commented Oct 10, 2022 •
edited by lhoestq
Loading

Close #5093

lhoestq
lhoestq approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks !

@lhoestq lhoestq merged commit bef23be into huggingface:main Oct 10, 2022
@lhoestq
Copy link
Member

lhoestq commented Oct 10, 2022 •
edited
Loading

Oops I merged without linking to the hacktoberfest issue - not sure if it counts in this case

sorry about that..

Next time you can just mention "Close #XXXX" in your issue to link it

@mariosasko
Copy link
Collaborator

It should :) (the hacktoberfest repo topic is all that matters)

@mariosasko mariosasko mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch between tutoriel and doc
3 participants
@riccardobucco @lhoestq @mariosasko