#3337 Add typing overloads to Dataset.__getitem__ for mypy #3382
+69
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dref360
commented
Dec 6, 2021
|
Locally the |
lhoestq
reviewed
Dec 8, 2021
|
Thank you for fixing flake8! I think we are ready to merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typing overloads to Dataset.getitem for mypy
Fixes #3337
Iterable
Iterable from
collectionscannot have a type, so you can't doIterable[int]for example.typinghas a Generic version that builds upon the one fromcollections.Flake8
I had to add
# noqa: F811, this is a bug from Flake8.datasets uses flake8==3.7.9 which released in October 2019 if I update flake8 (4.0.1), I no longer get these errors, but I did not want to make the update without your approval. (It also triggers other errors like no args in f-strings.)