Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define custom model/dataset URLs #347

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

secondtruth
Copy link
Contributor

I finally had some time to tackle my feature request. This closes #324.

@nsarrazin nsarrazin self-assigned this Jul 17, 2023
@nsarrazin
Copy link
Collaborator

Hello and thanks for contributing! I think it would be nice to document the new parameters but to be honest I'm not sure how to document optional arguments for now, and I think that's outside the scope of this PR. Other than that it works great so I'll be merging it!

@nsarrazin nsarrazin merged commit ce2231f into huggingface:main Jul 17, 2023
@nsarrazin nsarrazin self-requested a review July 17, 2023 08:22
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* Add ability to define custom model/dataset URLs

* lint

---------

Co-authored-by: Nathan Sarrazin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Ability to define custom model/dataset URLs in MODELS
2 participants