Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some functions/names according to MOOSE #151

Open
BoZeng1997 opened this issue Jul 13, 2023 · 3 comments
Open

Update some functions/names according to MOOSE #151

BoZeng1997 opened this issue Jul 13, 2023 · 3 comments

Comments

@BoZeng1997
Copy link
Contributor

BoZeng1997 commented Jul 13, 2023 •
edited
Loading

just to update some object parameter names, function names so that they stop throwing warnings. Changes include but not restricted to:

  1. The RankTwoTensor initializer in PhaseFieldJIntegral
  2. The "f_name" to "property_name" in CrackGeometricFunction and DegradationFunctionBase
  3. all test files using object mentioning 'f_name"
BoZeng1997 added a commit to BoZeng1997/raccoon that referenced this issue Aug 8, 2023
@BoZeng1997
update fuction/property names after moose update hugary1995#151
573c86e
BoZeng1997 added a commit to BoZeng1997/raccoon that referenced this issue Sep 27, 2023
@BoZeng1997
restore f_name in CrackGeometricFunction.C and DegradationFunctionBas…
9b8580a 
…e.C hugary1995#151
@lyyc199586
Copy link
Contributor

I think we still have "f_name" elsewhere, maybe we should open an issue to just update them

@BoZeng1997
Copy link
Contributor Author

I think we still have "f_name" elsewhere, maybe we should open an issue to just update them

In fact, this is the one. I just did not update the Description.

@lyyc199586
Copy link
Contributor

I mean where is the PR, did you already merged it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyyc199586 @BoZeng1997