Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sse log change to femme and kv_log_macro #902

Merged
merged 1 commit into from May 20, 2023
Merged

Fix sse log change to femme and kv_log_macro #902

merged 1 commit into from May 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2023

Fixed below two things in sse.

  1. Use the git version of tide, I had below error. Fixed it refere Stop re-exporting logging details from tide::log #889.
error[E0433]: failed to resolve: could not find `error` in `log`
  --> tide/src/sse/endpoint.rs:51:22
   |
51 |                 log::error!("SSE handler error: {:?}", err);
   |                      ^^^^^ could not find `error` in `log`

error[E0433]: failed to resolve: could not find `error` in `log`
  --> tide/src/sse/upgrade.rs:22:18
   |
22 |             log::error!("SSE handler error: {:?}", err);
   |                  ^^^^^ could not find `error` in `log`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `tide` due to 2 previous errors
  1. example/sse.rs had build error.
error[E0425]: cannot find function `start` in module `tide::log`
 --> examples/sse.rs:5:16
  |
5 |     tide::log::start();
  |                ^^^^^ not found in `tide::log`
  |
help: consider importing one of these items
  |
1 | use femme::start;
  |
1 | use logtest::start;
  |
help: if you import `start`, refer to it directly
  |
5 -     tide::log::start();
5 +     start();
  |

For more information about this error, try `rustc --explain E0425`.
error: could not compile `tide` due to previous error

@joshtriplett joshtriplett merged commit 7647a89 into http-rs:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant