copy headers instead of referencing them so they don't unexpectedly get overwritten #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function(e) { outgoing[e] = req[e]; } | ||
| ); | ||
| outgoing.method = req.method | ||
| outgoing.headers = extend({},req.headers) |
There was a problem hiding this comment.
Could you add a space after the empty object passed to extend? Also add a semicolon to the end;
|
I've updated my branch - please have a look (^_^) Also, I admire your team's strict adherence to your style guide. I'm usually much lazier than I should be haha. I did some Googling and found this. Should contributors be following that? |
|
@richardkazuomiller yea essentially, good find! That should just be linked somewhere. @indexzero just hasn't formalized a |
jcrugzz
added a commit
that referenced
this pull request
Nov 12, 2014
copy headers instead of referencing them so they don't unexpectedly get overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
common.setupOutgoinguses a reference to the original request headers, which causesConnectionto be overwritten in some cases, andHostto be overwritten whenchangeOriginis set totrue. If you use theproxyReqto look at the original request and the proxy request you will find that those headers have been modified on the original request object.I modified one test case that set the request headers to a string because using
utils._extendon a string doesn't work. As far as I knowreq.headerswill always be an object so I think what I did is fine but if there's a reason that was a string, I'll fix it so it checks the type.