Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds a flag to ProxyRequest to disable the setting of x-forwarded-[for|port|proto] #73

Merged
merged 2 commits into from
Jul 21, 2011

Conversation

DanBUK
Copy link
Contributor

@DanBUK DanBUK commented Jul 19, 2011

When using multiple layers of proxies one needs the ability not to re-set x-forwarded-[for|port|proto] on every layer; as the first proxy sets these headers on further layers the headers should not be clobbered so the final destination sees the correct address.

@indexzero
Copy link
Contributor

camelCase options are preferred over camel_case options (it's Javascript, not Ruby afterall). Can you please rename this to enableXForwarded and I will accept it.

@DanBUK
Copy link
Contributor Author

DanBUK commented Jul 19, 2011

Updated!

@indexzero
Copy link
Contributor

This should be true by default:

options.enableXForwarded = options.enableXForwarded === true;

dominictarr added a commit that referenced this pull request Jul 21, 2011
This adds a flag to ProxyRequest to disable the setting of x-forwarded-[for|port|proto]
(will change default to true in next commit)
@dominictarr dominictarr merged commit 76aa982 into http-party:master Jul 21, 2011
@dominictarr
Copy link
Contributor

defaults to true in e3d95ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants