Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug that generates an unexpected TypeError #383

Merged
merged 1 commit into from
Mar 18, 2013
Merged

Fixed a bug that generates an unexpected TypeError #383

merged 1 commit into from
Mar 18, 2013

Conversation

subnetmarco
Copy link
Contributor

This pull request fixes a bug that generates the following exception:

TypeError: Parameter 'url' must be a string, not undefined
at Object.urlParse [as parse] (url.js:96:11)
at ClientRequest.<anonymous> (/usr/lib/node_modules/test/node_modules/http-proxy/lib/node-http-proxy/http-proxy.js:273:22)
at ClientRequest.g (events.js:192:14)
at ClientRequest.EventEmitter.emit (events.js:96:17)
at HTTPParser.parserOnIncomingClient [as onIncoming] (http.js:1569:7)
at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:111:23)
at Socket.socketOnData [as ondata] (http.js:1472:20)
at TCP.onread (net.js:404:27)

@subnetmarco
Fixing the if statement as it lead to 'TypeError: Parameter 'url' mus…
c9b6895 
…t be a string, not undefined' in certain cases
indexzero added a commit that referenced this pull request Mar 18, 2013
@indexzero
Merge pull request #383 from thefosk/master
ea10bb2 
Fixing a bug that generates an unexpected TypeError
@indexzero indexzero merged commit ea10bb2 into http-party:master Mar 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@subnetmarco @indexzero