Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized table based routing and changed its behavior to a more consistent one. #133

Closed
wants to merge 1 commit into from

Conversation

manast
Copy link

@manast manast commented Oct 18, 2011

"pizza.com/taco/muffins": "127.0.0.1:8099' -> 127.0.0.1:8099
"pizza.com/taco/muffins": "127.0.0.1:8099/pasta/tomato' -> 127.0.0.1:8099/pasta/tomato

"pizza.com/taco/muffins": "127.0.0.1:8099' -> 127.0.0.1:8099
"pizza.com/taco/muffins": "127.0.0.1:8099/pasta/tomato' -> 127.0.0.1:8099/pasta/tomato
@manast
Copy link
Author

manast commented Oct 18, 2011

It passes current unit tests but I could not write new unit tests for testing my specifics since I get an error if I do so which I have not yet figured out how to fix:

Error: EADDRINUSE, Address already in use

@max-mapper
Copy link
Contributor

@manast the test harness starts a separate single-use proxy for each entry in the proxytable and each proxy must have a unique port as per the way the test harness is implemented

@manast
Copy link
Author

manast commented Oct 19, 2011

@maxogden well, that was what I thought, but it seems as I never manage to find any port that is not already busy, because it keeps failing :/

@manast
Copy link
Author

manast commented Oct 19, 2011

well, for me it is insane, I can not manage to make it working and unfortunately I have to move on to other things... in order to make this unit tests scalable (right now I think there is far too few tests to say that this is production ready), it is needed a better approach than trying to figure out which ports are free by hand, maybe we could use a function that returns a unique port every time it is called or something, then we need to match that port in the tests later on...

@coderarity
Copy link
Contributor

Oops, seems like I did this again at #218. Not sure why there's so many more changes in your version though.

@indexzero
Copy link
Contributor

There have been a bunch of changes to this in master. If you're still having the same issue when we release the new version feel free to reopen.

@indexzero indexzero closed this Jul 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants