Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#107: Set x-forwarded-for header (amongst others) #110

Merged
merged 3 commits into from
Sep 21, 2011
Merged

#107: Set x-forwarded-for header (amongst others) #110

merged 3 commits into from
Sep 21, 2011

Conversation

jfhbrook
Copy link
Contributor

These commits should fix the bug where the x-forwarded family of http headers are not being added to proxied requests.

@indexzero
Copy link
Contributor

This looks good, but shouldn't:

  req.headers['x-forwarded-for']   = req.connection.remoteAddress || req.connection.socket.remoteAddress;

be

  req.headers['x-forwarded-for']   = req.connection.remoteAddress || req.socket.remoteAddress;

@jfhbrook
Copy link
Contributor Author

Yes. I thought I fixed that. >_<

edit: Fixed it.

AvianFlu added a commit that referenced this pull request Sep 21, 2011
#107: Set x-forwarded-for header (amongst others)
@AvianFlu AvianFlu merged commit e5693d2 into master Sep 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants