Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

before and after functions need a way to specify a type #537

Closed
jcrugzz opened this issue Dec 28, 2013 · 2 comments
Closed

before and after functions need a way to specify a type #537

jcrugzz opened this issue Dec 28, 2013 · 2 comments

Comments

@jcrugzz
Copy link
Contributor

jcrugzz commented Dec 28, 2013

@yawnt there is no way to currently splice in before or after functions currently as there is no general this.passes. We have passes for either web or ws which needs to be specified in some manner.

What do you think is the cleanest way to do so? We could pass a type parameter to the before and after functions as the first argument but that seems suboptimal.

Thoughts?
jcrugzz added a commit that referenced this issue Dec 29, 2013
@jcrugzz
[fix] add type to before and after to grab correct passes, fixes #…
c47adac 
…537
yawnt added a commit that referenced this issue Dec 29, 2013
@yawnt
Merge pull request #539 from nodejitsu/fix-before-after
2c8edc1 
[fix] add `type` to before and after to grab correct `passes`, fixes #537
@jcrugzz
Copy link
Contributor Author

jcrugzz commented Jan 8, 2014

fixed in c47adac. @cronopio this could definitely use some tests though!

@jcrugzz jcrugzz closed this as completed Jan 8, 2014
@cronopio
Copy link
Contributor

cronopio commented Jan 8, 2014

@jcrugzz yeah sure I'll take care asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cronopio @jcrugzz