Added keybind 'N' for sorting by PID #413

jakem72360 · 2020-12-19T14:49:16Z

N key was selected, as it seems to be free and is backwards compatible with top.

BenBE · 2020-12-20T10:24:21Z

Action.c

- { .key = " Arrows: ", .info = "scroll process list" },
- { .key = " Digits: ", .info = "incremental PID search" },
- { .key = " F3 /: ", .info = "incremental name search" },
- { .key = " F4 \\: ",.info = "incremental name filtering" },
- { .key = " F5 t: ", .info = "tree view" },
- { .key = " p: ", .info = "toggle program path" },
- { .key = " m: ", .info = "toggle merged command" },
- { .key = " Z: ", .info = "pause/resume process updates" },
- { .key = " u: ", .info = "show processes of a single user" },
- { .key = " H: ", .info = "hide/show user process threads" },
- { .key = " K: ", .info = "hide/show kernel threads" },
- { .key = " F: ", .info = "cursor follows process" },
- { .key = "   + -: ", .info = "expand/collapse tree" },
- { .key = " P M T: ", .info = "sort by CPU%, MEM% or TIME" },
- { .key = " I: ", .info = "invert sort order" },
- { .key = " F6 > .: ", .info = "select sort column" },
+ { .key = "  Arrows: ", .info = "scroll process list" },
+ { .key = "  Digits: ", .info = "incremental PID search" },
+ { .key = "  F3 /: ", .info = "incremental name search" },
+ { .key = "  F4 \\: ",.info = "incremental name filtering" },
+ { .key = "  F5 t: ", .info = "tree view" },
+ { .key = "  p: ", .info = "toggle program path" },
+ { .key = "  m: ", .info = "toggle merged command" },
+ { .key = "  Z: ", .info = "pause/resume process updates" },
+ { .key = "  u: ", .info = "show processes of a single user" },
+ { .key = "  H: ", .info = "hide/show user process threads" },
+ { .key = "  K: ", .info = "hide/show kernel threads" },
+ { .key = "  F: ", .info = "cursor follows process" },
+ { .key = " F6 + -: ", .info = "expand/collapse tree" },
+ { .key = " N P M T: ", .info = "sort by PID, CPU%, MEM% or TIME" },
+ { .key = "  I: ", .info = "invert sort order" },
+ { .key = "  F6 > .: ", .info = "select sort column" },


Resizing the key column causes too much unnecessary noise in the patch.

BenBE · 2020-12-20T10:25:13Z

Action.c

- mvaddstr(line + item, 9, helpLeft[item].info);
+ mvaddstr(line + item, 10, helpLeft[item].info);
 attrset(CRT_colors[HELP_BOLD]);
 mvaddstr(line + item, 0, helpLeft[item].key);
- if (String_eq(helpLeft[item].key, " H: ")) {
+ if (String_eq(helpLeft[item].key, "  H: ")) {
 attrset(CRT_colors[PROCESS_THREAD]);
- mvaddstr(line + item, 32, "threads");
- } else if (String_eq(helpLeft[item].key, " K: ")) {
+ mvaddstr(line + item, 33, "threads");
+ } else if (String_eq(helpLeft[item].key, "  K: ")) {
 attrset(CRT_colors[PROCESS_THREAD]);
- mvaddstr(line + item, 26, "threads");
+ mvaddstr(line + item, 27, "threads");


Further resize-related noise.

BenBE · 2020-12-20T10:25:31Z

Action.c

- mvaddstr(line + item, 40, helpRight[item].key);
+ mvaddstr(line + item, 41, helpRight[item].key);
 attrset(CRT_colors[DEFAULT_COLOR]);
- mvaddstr(line + item, 49, helpRight[item].info);
+ mvaddstr(line + item, 50, helpRight[item].info);


BenBE · 2020-12-20T10:26:40Z

Action.c

+ { .key = " H: ", .info = "hide/show user process threads" },
+ { .key = " K: ", .info = "hide/show kernel threads" },
+ { .key = " F: ", .info = "cursor follows process" },
+ { .key = " F6 + -: ", .info = "expand/collapse tree" },


F6 is no more.

jakem72360 · 2020-12-20T11:13:32Z

What would your suggestion be? Adding the keybind to key in helpLeft would violate the leading space. Adding more padding causes the info section of the line to be cut off. Hardcoding coordinates is flimsy in general, and this seemed like the most logical solution.

I'm happy to change the patch, and am open to suggestions...

BenBE · 2020-12-20T14:27:02Z

Instead of adding spaces everywhere I think it'd be less noise, if just the horizontal offset of everything was shifted to the right by one. The entry you need to actually update has two spaces at the front, thus you could fit it in there.

An alternative was to split the PMT line entirely (One function per line) and shuffle things from the left to the right (or vice versa) and add the N shortcut in a second commit.

jakem72360 · 2020-12-20T14:56:19Z

I've updated it with changes only to the hardcoded X positions. I had assumed the leading spaces were desired, as they were present in both arrays.

Regarding splitting the sort functions onto multiple lines, I'll leave that decision to you. I think it looks better being one character wider, than a column being three lines longer. But like I said, it's up to you.

Draw the FunctionBar within Panel_draw instead of manually throughout the code. Add an optional PanelClass function drawFunctionBar, to allow specific panels to override the default FunctionBar_draw call. Rework the code on color change, to really change all colors (selection markers and panel headers). Closes: #402

- drop unused kinfo includes and link argument - detect kvm library necessity at configure step - fix variable typo

- move some functions to file scope - drop unused global variable

fasterit · 2020-12-21T13:48:40Z

see Action.c a bit below your inserted line:

   keys['n'] = actionIncNext;
   keys['N'] = actionIncPrev;

Either we remove these bindings or we need to find something else to map to PID sorting.

Avoid accidental duplicate usage.

Fixes #361

…ones-resize_bar

…into BenBE-harden_makecommandstr

jakem72360 · 2020-12-23T05:06:54Z

I just noticed that. What do you think is best? If we remove the original bindings, we can preserve some compatibility with top. If we keep those bindings, I'd suggest the D key as it's the only letter in PID not already in use. For now, I'll update the PR with the D binding.

Merge changes from master

fasterit · 2020-12-23T10:53:23Z

I just noticed that. What do you think is best?

I think we should remove the old n / N bindings and the stale code they call.
I asked on IRC what fellow devs think about this. That would free the "N" key then for PID sorting.
o/ DLange

jakem72360 · 2020-12-23T16:27:13Z

I think we should remove the old n / N bindings and the stale code they call.
I asked on IRC what fellow devs think about this. That would free the "N" key then for PID sorting.
o/ DLange

Created #425 with proposal for code removal

fasterit · 2020-12-23T17:34:47Z

Merged the patch (fixed back to using the N key) in the series up to f1463fd.

Thank you very much!

jakem72360 mentioned this pull request Dec 19, 2020

Option to disable sorting when in tree view #399

Closed

BenBE requested changes Dec 20, 2020

View reviewed changes

cgzones and others added 9 commits December 20, 2020 17:01

Use variable-length-array instead of small dynamic allocation

358d206

MetersPanel: drop color interruption in FunctionBar

3f9c63d

Position help labels one step to the right

4c86d7a

Added keybind 'N' for sorting by PID

3aba446

Minor typo and comment clarification

5fa1c70

Make remaining number literals use uppercase

4a73e80

DragonFlyBSD update

8db8b9e

- drop unused kinfo includes and link argument - detect kvm library necessity at configure step - fix variable typo

DragonFlyBSD update

9a86577

- move some functions to file scope - drop unused global variable

cgzones and others added 15 commits December 21, 2020 15:53

Action: sort key binding assignments

a09ad6b

Avoid accidental duplicate usage.

De-lazy @cgzones :)

9b8b380

Document dynamic bindings and assumed external configuration

0685613

Avoid NULL dereference on zombie processes

10c6810

Fixes #361

InfoScreen: drop unused member

3ec8f67

TraceScreen: mark local class functions static

a7612b0

EnvScreen: mark local class functions static

64c05a1

Panel_init: initialize selectedLen member

cdfd407

DiD: Ensure string offsets are inside string boundaries

6502b02

Merge branch 'resize_bar' of https://github.com/cgzones/htop into cgz…

737cd61

…ones-resize_bar

Merge branch 'harden_makecommandstr' of https://github.com/BenBE/htop …

fc7aead

…into BenBE-harden_makecommandstr

Resolve clang-analyzer signed/unsigned comparison CI failure

dfb9b82

Merge branch 'misc' of https://github.com/cgzones/htop into cgzones-misc

3fb0024

Bump version number for 3.0.4 release

0b989ee

Update version number for git repo builds

0672be7

fasterit added this to the 3.0.5 milestone Dec 22, 2020

Jake Mannens added 4 commits December 23, 2020 16:14

Changed PID keybind to 'D'

aab9ac8

Position help labels one step to the right

7974370

Added keybind 'N' for sorting by PID

2a0e2d2

Merge changes from master

Merge origin

7b8ffcb

fasterit closed this Dec 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added keybind 'N' for sorting by PID #413

Added keybind 'N' for sorting by PID #413

jakem72360 commented Dec 19, 2020

BenBE Dec 20, 2020

BenBE Dec 20, 2020

BenBE Dec 20, 2020

BenBE Dec 20, 2020

jakem72360 commented Dec 20, 2020

BenBE commented Dec 20, 2020

jakem72360 commented Dec 20, 2020

fasterit commented Dec 21, 2020

jakem72360 commented Dec 23, 2020

fasterit commented Dec 23, 2020 •

edited

Loading

jakem72360 commented Dec 23, 2020

fasterit commented Dec 23, 2020

Added keybind 'N' for sorting by PID #413

Added keybind 'N' for sorting by PID #413

Conversation

jakem72360 commented Dec 19, 2020

BenBE Dec 20, 2020

Choose a reason for hiding this comment

BenBE Dec 20, 2020

Choose a reason for hiding this comment

BenBE Dec 20, 2020

Choose a reason for hiding this comment

BenBE Dec 20, 2020

Choose a reason for hiding this comment

jakem72360 commented Dec 20, 2020

BenBE commented Dec 20, 2020

jakem72360 commented Dec 20, 2020

fasterit commented Dec 21, 2020

jakem72360 commented Dec 23, 2020

fasterit commented Dec 23, 2020 • edited Loading

jakem72360 commented Dec 23, 2020

fasterit commented Dec 23, 2020

fasterit commented Dec 23, 2020 •

edited

Loading