Fix dlopen issue for libsensors5 in Debian Buster, Bullseye #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsensors.so is provided only by the -dev package, so search for libsensors.so.5 (installed from the libsensors5 package) explicitly see: dpkg-query -S libsensors.so
BenBE
reviewed
Dec 12, 2020
Comment on lines
+24
to
+30
| dlopenHandle = dlopen("libsensors.so.", RTLD_LAZY); | ||
| if (!dlopenHandle) { | ||
| /* Debian contains no unversioned .so in libsensors5, only in the -dev package, so work around that: */ | ||
| dlopenHandle = dlopen("libsensors.so.5", RTLD_LAZY); | ||
| if (!dlopenHandle) | ||
| goto dlfailure; | ||
| } |
There was a problem hiding this comment.
Suggested change
| dlopenHandle = dlopen("libsensors.so.", RTLD_LAZY); | |
| if (!dlopenHandle) { | |
| /* Debian contains no unversioned .so in libsensors5, only in the -dev package, so work around that: */ | |
| dlopenHandle = dlopen("libsensors.so.5", RTLD_LAZY); | |
| if (!dlopenHandle) | |
| goto dlfailure; | |
| } | |
| /* Debian: workaround for unversioned .so for libsensors5 being present only in -dev package */ | |
| dlopenHandle = dlopen("libsensors.so.", RTLD_LAZY); | |
| if (!dlopenHandle) | |
| dlopenHandle = dlopen("libsensors.so.5", RTLD_LAZY); | |
| if (!dlopenHandle) | |
| goto dlfailure; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsensors.so is provided only by the -dev package, so search for
libsensors.so.5 (installed from the libsensors5 package) explicitly
see: dpkg-query -S libsensors.so