Skip to content

Commit

Permalink
Improve feedback when moving meters.
Browse files Browse the repository at this point in the history
  • Loading branch information
hishamhm committed Aug 27, 2015
1 parent f6c31ee commit 6082db2
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 8 deletions.
4 changes: 2 additions & 2 deletions AvailableMetersPanel.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ static inline void AvailableMetersPanel_addMeter(Header* header, Panel* panel, M
Meter* meter = (Meter*) Header_addMeterByClass(header, type, param, column);
Panel_add(panel, (Object*) Meter_toListItem(meter, false));
Panel_setSelected(panel, Panel_size(panel) - 1);
((MetersPanel*)panel)->moving = true;
((ListItem*)Panel_getSelected(panel))->moving = true;
MetersPanel_setMoving((MetersPanel*)panel, true);
FunctionBar_draw(panel->currentBar, NULL);
}

static HandlerResult AvailableMetersPanel_eventHandler(Panel* super, int ch) {
Expand Down
29 changes: 23 additions & 6 deletions MetersPanel.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,29 +34,43 @@ static const char* MetersFunctions[] = {"Type ", "Move ", "Delete", "Done ",
static const char* MetersKeys[] = {"Space", "Enter", "Del", "Esc"};
static int MetersEvents[] = {' ', 13, KEY_DC, 27};

static const char* MetersMovingFunctions[] = {"Up ", "Down ", "Left ", "Right ", "Confirm", "Delete", "Done ", NULL};
static const char* MetersMovingKeys[] = {"Up", "Dn", "Lt", "Rt", "Arrows", "Enter", "Del", "Esc"};
static int MetersMovingEvents[] = {KEY_UP, KEY_DOWN, KEY_LEFT, KEY_RIGHT, 13, KEY_DC, 27};
static FunctionBar* Meters_movingBar = NULL;

static void MetersPanel_delete(Object* object) {
Panel* super = (Panel*) object;
MetersPanel* this = (MetersPanel*) object;
Panel_done(super);
free(this);
}

void MetersPanel_setMoving(MetersPanel* this, bool moving) {
Panel* super = (Panel*) this;
this->moving = moving;
((ListItem*)Panel_getSelected(super))->moving = moving;
if (!moving) {
Panel_setDefaultBar(super);
} else {
super->currentBar = Meters_movingBar;
}
}

static inline bool moveToNeighbor(MetersPanel* this, MetersPanel* neighbor, int selected) {
Panel* super = (Panel*) this;
if (this->moving) {
if (neighbor) {
if (selected < Vector_size(this->meters)) {
((ListItem*)Panel_getSelected(super))->moving = false;
MetersPanel_setMoving(this, false);

Meter* meter = (Meter*) Vector_take(this->meters, selected);
Panel_remove(super, selected);
Vector_insert(neighbor->meters, selected, meter);
Panel_insert(&(neighbor->super), selected, (Object*) Meter_toListItem(meter, false));
Panel_setSelected(&(neighbor->super), selected);

this->moving = false;
neighbor->moving = true;
((ListItem*)Panel_getSelected((Panel*)neighbor))->moving = true;
MetersPanel_setMoving(neighbor, true);
return true;
}
}
Expand All @@ -78,8 +92,8 @@ static HandlerResult MetersPanel_eventHandler(Panel* super, int ch) {
{
if (!Vector_size(this->meters))
break;
this->moving = !(this->moving);
((ListItem*)Panel_getSelected(super))->moving = this->moving;
MetersPanel_setMoving(this, !(this->moving));
FunctionBar_draw(this->super.currentBar, NULL);
result = HANDLED;
break;
}
Expand Down Expand Up @@ -183,6 +197,9 @@ MetersPanel* MetersPanel_new(Settings* settings, const char* header, Vector* met
MetersPanel* this = AllocThis(MetersPanel);
Panel* super = (Panel*) this;
FunctionBar* fuBar = FunctionBar_new(MetersFunctions, MetersKeys, MetersEvents);
if (!Meters_movingBar) {
Meters_movingBar = FunctionBar_new(MetersMovingFunctions, MetersMovingKeys, MetersMovingEvents);
}
Panel_init(super, 1, 1, 1, 1, Class(ListItem), true, fuBar);

this->settings = settings;
Expand Down
3 changes: 3 additions & 0 deletions MetersPanel.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ struct MetersPanel_ {
};



void MetersPanel_setMoving(MetersPanel* this, bool moving);

extern PanelClass MetersPanel_class;

MetersPanel* MetersPanel_new(Settings* settings, const char* header, Vector* meters, ScreenManager* scr);
Expand Down

0 comments on commit 6082db2

Please sign in to comment.