Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of six.binary_type #400

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Remove unnecessary use of six.binary_type #400

merged 1 commit into from
Oct 1, 2018

Conversation

jdufresne
Copy link
Contributor

The bytes type is available on all support Pythons. On Python 2 it is an alias of str (same as six). Reduce unnecessary compatibility shims and by using modern Python idioms. Makes the code more forward compatible with Python 3.

The bytes type is available on all support Pythons. On Python 2 it is an
alias of str (same as six). Reduce unnecessary compatibility shims and
by using modern Python idioms. Makes the code more forward compatible
with Python 3.
Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mildly amazed this is actually the only place we use it, but seemingly it is! I presume elsewhere we check for text_type and branch if/else on that.

@gsnedders gsnedders merged commit fd04f6a into html5lib:master Oct 1, 2018
@jdufresne jdufresne deleted the binary-type branch February 26, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants