Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppVeyor testing #359

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Add AppVeyor testing #359

merged 2 commits into from
Nov 9, 2017

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Nov 8, 2017

This is the first subset of #293 .

@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 8, 2017

@willkg
Copy link
Contributor

willkg commented Nov 8, 2017

After we land this, we need to set up appveyor as a CI thing, right? Is there anything else we need to do?

@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 8, 2017

Not mandatory; devs can just do it on their forks if you're not keen on it being part of the PR process.

I've chosen to use .appveyor.yml instead of the default appveyor.yml , which means that there is one additional setup step : specifying the file in the AppVeyor settings.
I'm having to use the default filename if you'd prefer.

@willkg willkg added this to the 1.0 milestone Nov 8, 2017
@gsnedders
Copy link
Member

@willkg lmk if I need to do anything to enable AppVeyor on the repo!

Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you!

@willkg willkg merged commit 85bc5fa into html5lib:master Nov 9, 2017
@willkg
Copy link
Contributor

willkg commented Nov 9, 2017

@jayvdb Naming the file that is fine by me. I want this to be part of the PR process. I'll figure out whether I can add it on my own and if not, ping @gsnedders for help.

Thank you!

@gsnedders
Copy link
Member

gsnedders commented Nov 9, 2017

Now added. https://ci.appveyor.com/project/gsnedders/html5lib-python/build/1.0.1 ran this as landed.

@willkg
Copy link
Contributor

willkg commented Nov 10, 2017

@gsnedders Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants