Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localizable error messages #85

Closed
gsnedders opened this issue Jun 27, 2013 · 1 comment
Closed

Localizable error messages #85

gsnedders opened this issue Jun 27, 2013 · 1 comment
Assignees
@gsnedders
Labels
api-breakage has-active-pull-request
Milestone
1.0

Comments

@gsnedders
Copy link
Member

Currently almost all our error messages are passed through gettext. Do we actually want localizable error messages? To me, at least, this seems an anti-feature.

cc/ @ambv and @jgraham
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue Jul 19, 2013
@gsnedders
Fix html5lib#85: remove localization of error messages.
cdb70b9 
It doesn't make sense to localize error messages, given they are
purely technical in content.
@ghost ghost assigned gsnedders Aug 13, 2013
@gsnedders gsnedders mentioned this issue Aug 20, 2013
Closed
@gsnedders
Copy link
Member Author

If we do decide to keep this, we should add tests to make sure everything is actually tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsnedders gsnedders

Labels
api-breakage has-active-pull-request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@gsnedders