fix: an error while executing trimShards should not interrupt the exe… #1707
Conversation
| trim shards r@Rid{..} | ||
| | rShardId `elem` shards = do | ||
| try (S.trim scLDClient rShardId (rBatchId - 1)) >>= \case | ||
| Left (e:: SomeException) |
There was a problem hiding this comment.
I tried SomeStoreException first, but I didn't find a way to pattern match SomeStoreException to a specific exception, such as S.TOOBIG
There was a problem hiding this comment.
I haven't looked at the details, but I think at least catches can do this job. You do not need to do pattern match.
There was a problem hiding this comment.
Does S.trim return exceptions other than SomeHStoreException, if not then catching SomeException and SomeHStoreException is actually the same?
Also, the requirement is that no exceptions should interrupt execution, so if it returns something else, even if I use catches, I still have to match SomeException.
There was a problem hiding this comment.
Does S.trim return exceptions other than SomeHStoreException
Yes, it's possible, but seldom.
if not then catching SomeException and SomeHStoreException is actually the same
No, they are not the same, for example, while dealing with AsyncException
so if it returns something else, even if I use catches, I still have to match SomeException
It depends on. But mostly, this is what you should not do.
PR Description
Type of change
Summary of the change and which issue is fixed
Main changes: TODO
Checklist
format.shunderscript