Run unit tests on Alpine docker too #19371
Conversation
| runs-on: ubuntu-latest | ||
| container: | ||
| image: alpine:latest | ||
| options: --shm-size=8g |
There was a problem hiding this comment.
This is the trick to make PPSSPPHeadless to work fine in the dockers
| @@ -137,7 +137,7 @@ void MemArena::ReleaseView(s64 offset, void* view, size_t size) { | |||
|
|
|||
| u8* MemArena::Find4GBBase() { | |||
| // Now, create views in high memory where there's plenty of space. | |||
| #if PPSSPP_ARCH(64BIT) && !defined(USE_ASAN) | |||
| #if PPSSPP_ARCH(64BIT) && !defined(USE_ASAN) && !defined(NO_MMAP) | |||
There was a problem hiding this comment.
Uncomplete condition here...
|
Btw @fjtrujy since you're familiar to building ppsspp on Alpine linux, i have a question :) Did you managed to build ppsspp statically linked without stdc++ dependency? because it always linked to libstdc++ when i tried to build it statically on Alpine linux. |
Being honest I didn’t pay attention to this, so I don’t know if internally it uses libstdc++. Shouldn’t be this cmake configuration? |
|
Well i tried searching for "stdc++" on ppsspp repo but can only found it at ios/macos/windows part of CMakeLists.txt/Makefile |
I think that now I understand your issue. |
|
|
||
| - name: Fix git detected dubious ownership in repository | ||
| run: | | ||
| chown -R $(id -u):$(id -g) $PWD |
There was a problem hiding this comment.
Hmm.. interesting to know that dubious ownership can be solved this way too.
I was using this for dubious ownership issue on my workflow:
# Fix dubious ownership issue when running git describe inside a container
git config --global --add safe.directory "$PWD"
|
@hrydgard all the tests are passing now and I have applied your suggestions. |
|
Just curious, this changes won't make everyone who forked ppsspp need to have Docker account, right? otherwise their build.yml will failed just like the https://github.com/hrydgard/ppsspp/blob/master/.github/workflows/generateDockerLayer.yml |
No, because we are uploading this docker file to the github repository, is not to Docker hub. It doesn't require any grants to do it. |
|
@hrydgard any pending thing? I want to merge this. |
|
Sorry, forgot that there wasn't more to do, heh. Let's get it in. |
Description
The scope of this PR is to check in the CI that Unit tests are working fine for the Alpine docker version too.
We are now also offering the possibility of setting the
NO_MMAPflag in the compilation scripts.Current behavior with this flag is not stable, as some unit tests are not passing and with some other is crashing, this is why I have added it to the matrix of testing.
Some other minor changes have been made.
Cheers.