[Core/GPU] Fixed condition blocks where result always true #19040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anr2me
reviewed
Apr 11, 2024
| @@ -477,7 +477,7 @@ static void DataProcessingRegister(uint32_t w, uint64_t addr, Instruction *instr | |||
| int imm3 = (w >> 10) & 0x7; | |||
| if (Rd == 31 && sub && S) { | |||
| // It's a CMP | |||
| snprintf(instr->text, sizeof(instr->text), "%s%s %c%d, %c%d, %s", "cmp", S ? "s" : "", r, Rn, r, Rm, extendnames[option]); | |||
There was a problem hiding this comment.
just wondering, how did a conditional S became a constant "s"?
Since w is a type of uint32_t that came from argument and bool S = (w >> 29) & 1; Which part of the code causing S to have a fixed/constant value of true?
Edit: oops sorry, it was the entry condition where S need to be true to reach this part of the code
|
This PR is waiting for actions. |
hrydgard
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.