Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer Enhancement for Windows #18381

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

OtavioProfeta
Copy link

Hello, I'm a junior Front-end developer and I have knowledge in software packaging. Therefore, I made some improvements to the PPSSPP installer:

  • The language selection box has been removed, so that the installer recognizes the system's own language and prevents the icon from becoming invisible (Problem presented in Windows 10).

  • Options have been added so that the user can add PPSSPP shortcuts to the start menu and desktop.

  • A PPSSPP icon was added to the installer itself, making it more authentic.

  • A 128x128 image in .bmp format has been added to the top right corner of the installer pages.

  • Due to a change in the latest version of inno setup, I had to manually add the classic image at the end of the installation.

@OtavioProfeta OtavioProfeta changed the title Otavio profeta Installer Enhancement for Windows Oct 25, 2023
@hrydgard
Copy link
Owner

Nice!

I'm going to make a few tweaks before merging, like add a gold icon bmp. Will do that fairly soon.

@Nemoumbra
Copy link
Contributor

Why does the language select screen have to be removed? Or rather... Why does it cause some icons to disappear?

By the way, what does this even mean, can I see a screenshot pretty please? Forgive my curiosity.

@OtavioProfeta OtavioProfeta deleted the Otavio-Profeta branch March 4, 2024 23:24
@OtavioProfeta OtavioProfeta restored the Otavio-Profeta branch March 4, 2024 23:25
@OtavioProfeta OtavioProfeta reopened this Mar 4, 2024
@OtavioProfeta OtavioProfeta deleted the Otavio-Profeta branch March 4, 2024 23:39
@OtavioProfeta OtavioProfeta restored the Otavio-Profeta branch March 4, 2024 23:39
@OtavioProfeta OtavioProfeta reopened this Mar 4, 2024
@OtavioProfeta
Copy link
Author

Why does the language select screen have to be removed? Or rather... Why does it cause some icons to disappear?

**From what I was able to find out the icons disappear due to some problem in Inno Setup when using Unicode from other languages in the part that defines the translation of the "SetupAppTitle". You can address this bug by assigning the same translation value for all languages like this:

[Messages]
english.SetupAppTitle=Setup - PPSSPP
brazilianportuguese.SetupAppTitle=Setup - PPSSPP
german.SetupAppTitle=Setup - PPSSPP
french.SetupAppTitle=Setup - PPSSPP
italian.SetupAppTitle=Setup - PPSSPP
spanish.SetupAppTitle=Setup - PPSSPP
japanese.SetupAppTitle=Setup - PPSSPP
polish.SetupAppTitle=Setup - PPSSPP
russian.SetupAppTitle=Setup - PPSSPP**

By the way, what does this even mean, can I see a screenshot pretty please? Forgive my curiosity.

Captura

Sorry for the mess when replying, I ended up deleting the comment a few times when replying to you.!

Copy link

@g1therd0n3 g1therd0n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants