GPU: Ignore depth when masked and ALWAYS #16183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen in NFS Pro Street, for example. Shouldn't be interpreted as depth usage.
We don't do it when creating framebufs either, so don't update to matching values.
This is inclusive.
These drivers apparently have some weird behavior.
|
Good stuff all around. |
hrydgard
approved these changes
Oct 9, 2022
sum2012
reviewed
Oct 9, 2022
| @@ -848,8 +848,9 @@ VKContext::VKContext(VulkanContext *vulkan) | |||
| } | |||
|
|
|||
| // Older ARM devices have very slow geometry shaders, not worth using. At least before 15. | |||
There was a problem hiding this comment.
Well, I don't know that at say 17 are slow, but they're apparently broken.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16175. Fixes at least the artifacts underneath the car.
In this case, the game was using:
It was a case of fb_address == z_address. So we shouldn't set the depth used in this case, and we also should refuse to set them matching as we do elsewhere.
-[Unknown]