Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.deprecate should not be used until neovim 0.9.0 #40

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

wookayin
Copy link
Contributor

vim.deprecate is not available yet as of neovim 0.8.0. The use of it
(introduced in #35) will break stable versions of neovim.

@wookayin
Copy link
Contributor Author

For neovim <= 0.8.0, it will have no deprecation warnings but at the moment it will be fine. But if you would like to have deprecation warnings printed even before 0.9.0 (i.e., including the stable versions), we can use some other ways like simple vim.notify or print. That said, it's better have the plugin NOT broken than having no messages...

lua/cmp_nvim_lsp/init.lua Outdated Show resolved Hide resolved
vim.deprecate is not available yet as of neovim 0.8.0. The use of it
(introduced in hrsh7th#35) will break stable versions of neovim.
@hrsh7th
Copy link
Owner

hrsh7th commented Oct 15, 2022

LGTM.,Thank you!

@hrsh7th hrsh7th merged commit 3cf38d9 into hrsh7th:main Oct 15, 2022
@wookayin
Copy link
Contributor Author

Correction: vim.deprecate is introduced in and available in 0.8.0 ( neovim/neovim@73741e9); I thought it was since 0.9.0-nightly because helpful.vim reports so. Anyway it would be good to maintain some backward compatibility for a while (e.g., nvim-cmp's minimum supported version is still 0.7.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants