Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lumentis folder to gitignore #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdcorps
Copy link

@bdcorps bdcorps commented Mar 30, 2024

The .lumentis folder is not git ignored at the moment. This makes sure that that folder is not committed to Git.

@eugene-yaroslavtsev
Copy link
Contributor

I think this shouldn’t be ignored because:

  1. it shouldn’t end up in this directory at all - it’s gonna be in whatever clean new dir you run lumentis in.
  2. I think it has super important data and should actually be checked in with the auto-generated doc site because:
  • I’ve found myself often referring to it if I stop a lumentis run midway and want to tweak something - being gitignored means it also disappears from most folks’ IDEs (if they have “hide gitignore files/dirs enabled)
  • if/when we add “update mode”, having the previous generation metadata is basically gonna be required

@hrishioa we briefly discussed before - WDYT?

@hrishioa
Copy link
Owner

hrishioa commented Apr 6, 2024

I see exactly where you're coming from - and I'm kind of split on this.

The original intent with leaving it out of .gitignore was that the original transcript is embedded in the messages in the Lumentis folder - and those felt sensitive to commit to VCS. The config also has the same problem.

Two options I think we should consider:

  1. We make this an optional question in the wizard - but we'll likely need to condense this and a bunch of other questions into a poweruser mode since the wizard is getting a bit long. If we do that I'm happy for this (including .lumentis folder) to be on by default.
  2. We split the transcript out of the wizardState, and the messages folder, and we only commit the rest.

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants