Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: Deep URL navigation to study editor using Navigator 2.0 #8

Merged
merged 15 commits into from
Feb 2, 2021

Conversation

nstrelow
Copy link
Contributor

@nstrelow nstrelow commented Feb 2, 2021

  • Improve ParseFutureBuilder and RetryFutureBuilder reload behavior (fewer reloads)
  • Migrate Designer to Navigator 2.0: RootRouter for dashboard/designer + DesignerRouter for different editors

Instead of managing state just inside the retryFutureBuilder,
the state of the queryFunction is saved inside ParseFutureBuilder.

This is a workaround for not triggering the future function every time
the widget is rebuilt. This was the case, because the queryFunction
would be wrapped in a class function. This function was being rebuilt
every time the ParseFutureBuilder was rebuild, therefore
the RetryFutureBuilder would retrigger the future.

Now the future is only reloaded, if the queryFunction object changes.
Reloading can now be triggered by the caller of ParseFutureBuilder
by setting a new queryFunction
URL now always matches what is displayed
URL also directly opens study in designer
Failed saving the file in InelliJ Idea before commit
@nstrelow nstrelow merged commit d3f9e24 into dev Feb 2, 2021
@jannis-baum jannis-baum deleted the navigator_2.0 branch June 9, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant