Designer: Deep URL navigation to study editor using Navigator 2.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nstrelow
commented
Feb 2, 2021
nstrelow
commented
- Improve ParseFutureBuilder and RetryFutureBuilder reload behavior (fewer reloads)
- Migrate Designer to Navigator 2.0: RootRouter for dashboard/designer + DesignerRouter for different editors
Instead of managing state just inside the retryFutureBuilder, the state of the queryFunction is saved inside ParseFutureBuilder. This is a workaround for not triggering the future function every time the widget is rebuilt. This was the case, because the queryFunction would be wrapped in a class function. This function was being rebuilt every time the ParseFutureBuilder was rebuild, therefore the RetryFutureBuilder would retrigger the future. Now the future is only reloaded, if the queryFunction object changes. Reloading can now be triggered by the caller of ParseFutureBuilder by setting a new queryFunction
URL now always matches what is displayed URL also directly opens study in designer
Failed saving the file in InelliJ Idea before commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.