Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce study status and add closing state #634

Merged
merged 24 commits into from
Jun 19, 2024
Merged

feat: Introduce study status and add closing state #634

merged 24 commits into from
Jun 19, 2024

Conversation

johannesvedder
Copy link
Contributor

@johannesvedder johannesvedder commented May 25, 2024 •
edited

PR changes:

  • New Close button added to running studies and integrate closed as a state into the study database model. published has been deprecated.
  • New database policies which forbid modification of study columns when study is not in draft mode, except 'updated_at', 'status', 'registry_published', and 'result_sharing'
    • Migrate App
  • Add separator for study popup menu

Possible Test cases to Review

  1. Checkout the branch and start a new database using the Supabase CLI for StudyU
  2. Log into the Designer and launch a new public study
  3. Log in with another user and check that they are unable to close the study from the study registry
  4. Open up the app and start the study as a participant
  5. Change to the first user again who owns the study and close the study
  6. Check in the app that the participant is still able to continue the study, even though the study has been closed
  7. Start a new session with the app and check that the study is not shown anymore in the study list, since it is closed
  8. ??

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Visit the preview URL for this PR (updated for commit 931c4e2):

(expires Fri, 21 Jun 2024 07:38:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

@johannesvedder johannesvedder force-pushed the feat/study-closing-studystatus branch 2 times, most recently from 235acd5 to e4fae75 Compare May 26, 2024 09:52
@johannesvedder johannesvedder force-pushed the feat/study-closing-studystatus branch from c643ed5 to f312f3e Compare May 27, 2024 20:35
@johannesvedder johannesvedder marked this pull request as draft June 7, 2024 12:22
@johannesvedder johannesvedder marked this pull request as ready for review June 7, 2024 14:39
@github-actions github-actions bot added dependencies Pull requests that update a dependency file flutter_common labels Jun 10, 2024
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file flutter_common labels Jun 10, 2024
@ibrahimozkn ibrahimozkn self-requested a review June 10, 2024 23:41
@rajuAhmed1705
Copy link

Hi, I tried to launch a new study. after inputting all the values, when I press Launch it does not work some how. You will find the screen record for this in the following link. Google Drive.

@johannesvedder
Copy link
Contributor Author

Hi, I tried to launch a new study. after inputting all the values, when I press Launch it does not work some how. You will find the screen record for this in the following link. Google Drive.

The loading widget on top is spinning which means the study hasn't been saved correctly. I have made some additions to the PR fixing different things. Please test again.

@johannesvedder johannesvedder force-pushed the feat/study-closing-studystatus branch 2 times, most recently from 9374962 to c9c1fa6 Compare June 11, 2024 16:58
@johannesvedder
Merge branch 'dev' into feat/study-closing-studystatus
f190d1f 
# Conflicts:
#	core/lib/src/models/tables/study.dart
#	core/lib/src/models/tables/study_subject.dart
#	core/lib/src/util/supabase_object.dart
#	designer_v2/lib/common_views/action_popup_menu.dart
#	designer_v2/lib/features/publish/study_publish_dialog.dart
#	designer_v2/lib/features/recruit/study_recruit_page.dart
#	designer_v2/lib/features/study/study_scaffold.dart
#	designer_v2/lib/features/study/study_status_badge.dart
#	designer_v2/lib/services/notifications.dart
#	designer_v2/lib/utils/model_action.dart
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file flutter_common labels Jun 12, 2024
@johannesvedder
chore: format
e27a580
@johannesvedder
chore: format
dad913e
@johannesvedder
style: rephrase translation
cdcbca5
@johannesvedder
feat: new severe close confirmation
9b66d33
@johannesvedder
Merge branch 'feat/study-closing' into feat/study-closing-studystatus
931c4e2 
# Conflicts:
#	core/lib/src/models/tables/study.dart
#	designer_v2/lib/common_views/action_popup_menu.dart
#	designer_v2/lib/features/recruit/study_recruit_page.dart
#	designer_v2/lib/repositories/study_repository.dart
#	designer_v2/lib/services/notifications.dart
#	designer_v2/lib/utils/model_action.dart
@github-actions github-actions bot removed documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file flutter_common labels Jun 14, 2024
ibrahimozkn
ibrahimozkn approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ibrahimozkn ibrahimozkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems working ✅

  • Checkout the branch and start a new database using the Supabase CLI for StudyU
  • Log into the Designer and launch a new public study
  • Log in with another user and check that they are unable to close the study from the study registry
  • Open up the app and start the study as a participant
  • Change to the first user again who owns the study and close the study
  • Check in the app that the participant is still able to continue the study, even though the study has been closed
  • Start a new session with the app and check that the study is not shown anymore in the study list, since it is closed

@johannesvedder johannesvedder merged commit 5c39a72 into feat/study-closing Jun 19, 2024
8 checks passed
@johannesvedder johannesvedder deleted the feat/study-closing-studystatus branch June 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajuAhmed1705 rajuAhmed1705 rajuAhmed1705 approved these changes

@ibrahimozkn ibrahimozkn ibrahimozkn approved these changes

Assignees

@johannesvedder johannesvedder

Labels
app core designer_v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johannesvedder @rajuAhmed1705 @ibrahimozkn