Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(designer_v2): Support Riverpod v2 #626

Merged
merged 64 commits into from
Jul 1, 2024
Merged

Conversation

johannesvedder
Copy link
Contributor

@johannesvedder johannesvedder commented May 23, 2024

Migration to Riverpod v2

Helpful guides

Todo (sorted by priority)

  • Intervention changes get deleted on modification of study schedule
    • --> workaround applied
  • Improved integration tests
  • Login/register notifications (wrong password, etc.) are not showing
  • Clicking on the last intervention of the default study throws error Exception: Bad state: No element
  • Invitation section, creating an invite code throws
  • Migrate providers in app_repository:27 and study_settings_form_controller.dart:89
  • Check in which cases the study model is updated after leaving the test view (refactor(designer_v2): Support Riverpod v2 #626 (comment))
  • Test section (needs testing, especially if live preview works)
  • Study is not saved but throws exceptions if no title is inserted. Warn user if this is the case and handle the error
  • Participation -> Add screener question -> Multiple Choice -> Add option (does not work)
  • Split screen test section of intervention form throws exception on saving
  • Similar errors when saving a survey

Review Instructions

Create a new complete study (including all possible elements), and check if modifications are saved instantly (visible by the loading icon top left). Any edit and delete operations to items should also be executed immediately on change (after debouncer timeout of around 1s).

@johannesvedder johannesvedder marked this pull request as draft May 23, 2024 15:42
@johannesvedder johannesvedder linked an issue May 23, 2024 that may be closed by this pull request
@github-actions github-actions bot added dependencies Pull requests that update a dependency file app designer_v2 labels May 27, 2024
Copy link

github-actions bot commented May 27, 2024

Visit the preview URL for this PR (updated for commit 37a0941):

(expires Mon, 08 Jul 2024 16:44:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

ibrahimozkn and others added 8 commits June 10, 2024 20:18
# Conflicts:
#	designer_v2/lib/common_views/pages/splash_page.dart
#	designer_v2/lib/features/analyze/study_analyze_controller.dart
#	designer_v2/lib/features/app.dart
#	designer_v2/lib/features/app_controller.dart
#	designer_v2/lib/features/auth/auth_form_controller.dart
#	designer_v2/lib/features/dashboard/dashboard_controller.dart
#	designer_v2/lib/features/design/study_form_controller.dart
#	designer_v2/lib/features/design/study_form_providers.dart
#	designer_v2/lib/features/recruit/invite_code_form_controller.dart
#	designer_v2/lib/features/recruit/study_recruit_controller.dart
#	designer_v2/lib/features/study/study_base_controller.dart
#	designer_v2/lib/features/study/study_controller.dart
#	designer_v2/lib/features/study/study_controller_state.dart
#	designer_v2/lib/features/study/study_test_controller.dart
#	designer_v2/lib/localization/app_translation.dart
#	designer_v2/lib/localization/language_picker.dart
#	designer_v2/lib/localization/locale_providers.dart
#	designer_v2/lib/localization/locale_state.dart
#	designer_v2/lib/repositories/api_client.dart
#	designer_v2/lib/repositories/invite_code_repository.dart
#	designer_v2/lib/repositories/supabase_client.dart
#	designer_v2/lib/routing/router.dart
#	designer_v2/lib/services/clipboard.dart
#	designer_v2/pubspec.yaml
@johannesvedder
Copy link
Contributor Author

johannesvedder commented Jun 17, 2024

.

…racters entered to password field on the registration page.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 1, 2024
@johannesvedder johannesvedder merged commit 6f5f781 into dev Jul 1, 2024
12 checks passed
@johannesvedder johannesvedder deleted the refactor/riverpod_2 branch July 1, 2024 16:46
@johannesvedder johannesvedder mentioned this pull request Jul 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app core dependencies Pull requests that update a dependency file designer_v2 documentation Improvements or additions to documentation flutter_common
Projects
None yet
3 participants