-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Flutter 3.0 #22
Conversation
75bc968
to
d51e1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to make the migration for this one and I'll try to document the process, especially updating packages and deploying :)
Playing around adding dependabot, so it's easier to upgrade dependencies.
environment: | ||
sdk: ">=2.7.0 <3.0.0" | ||
sdk: ">=2.7.0 <=3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the dart SDK, the newest version is 2.17 I think. Not the new Flutter sdk :)
You can think of it as the version of the language. app needs at least dart 2.7.0 sdk for all language features and so on. I need to upgrade this to a newer one, but for that we need to enable null safety, which is a huge migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, I missed that. I wasn't really sure if this needs to be upgraded. Is this handled by melos upgrade aswell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually this never needs to get upgraded, except if you are a package you are using needs a newer dart SDK version.
So you have to do it manually, but usually only when you get an error, saying you need to upgrade for X.
@@ -1,14 +1,13 @@ | |||
name: studyu_app | |||
description: An app to facilitate N-of-1 trials | |||
version: 1.10.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally do version upgrades via melos. I'll try to document it or make a video.
@@ -1,3 +1,7 @@ | |||
## 1.10.14 | |||
|
|||
- **FIX**: Upgrade dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some here, changelog are generated by melos using the conventional commits: https://www.conventionalcommits.org/en/v1.0.0/
Basically I use fix, feat, chore in commits like
fix: Upgrade deps
, feat: new feature
, docs: update readme
, chore something else
fix pushes the patch package version e.g. 1.10.13->1.10.14, feat, the minor: 1.10.13 -> 1.11.0
if you type BREAKING CHANGE somewhere in the commit it'll upgrade the major version 1.10.13->2.0.0
751b46e
to
101671b
Compare
The Issue: flutter-form-builder-ecosystem/flutter_form_builder#1021 It is a subdependency: Here is a PR fixing it, which has not been merged or published. To use Flutter 3.0.0 with designer, I would then set this as a dependency override. See my other PR.
|
Aaaand |
Okay, thanks for the review. We can just close this one when #45 is merged. |
The current setup (at least
designer
) does not build with Flutter v3.0. The following external (sub-)dependencies are affected: