Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flutter 3.0 #22

Closed
wants to merge 4 commits into from
Closed

Support for Flutter 3.0 #22

wants to merge 4 commits into from

Conversation

johannesvedder
Copy link
Contributor

The current setup (at least designer) does not build with Flutter v3.0. The following external (sub-)dependencies are affected:

  • tba

@johannesvedder johannesvedder self-assigned this May 12, 2022
@johannesvedder johannesvedder added the bug Something isn't working label May 12, 2022
@nstrelow nstrelow force-pushed the dev branch 2 times, most recently from 75bc968 to d51e1e5 Compare May 15, 2022 19:20
Copy link
Contributor

@nstrelow nstrelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to make the migration for this one and I'll try to document the process, especially updating packages and deploying :)

Playing around adding dependabot, so it's easier to upgrade dependencies.

environment:
sdk: ">=2.7.0 <3.0.0"
sdk: ">=2.7.0 <=3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the dart SDK, the newest version is 2.17 I think. Not the new Flutter sdk :)

You can think of it as the version of the language. app needs at least dart 2.7.0 sdk for all language features and so on. I need to upgrade this to a newer one, but for that we need to enable null safety, which is a huge migration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, I missed that. I wasn't really sure if this needs to be upgraded. Is this handled by melos upgrade aswell?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually this never needs to get upgraded, except if you are a package you are using needs a newer dart SDK version.

So you have to do it manually, but usually only when you get an error, saying you need to upgrade for X.

@@ -1,14 +1,13 @@
name: studyu_app
description: An app to facilitate N-of-1 trials
version: 1.10.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally do version upgrades via melos. I'll try to document it or make a video.

@@ -1,3 +1,7 @@
## 1.10.14

- **FIX**: Upgrade dependencies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some here, changelog are generated by melos using the conventional commits: https://www.conventionalcommits.org/en/v1.0.0/

Basically I use fix, feat, chore in commits like
fix: Upgrade deps, feat: new feature, docs: update readme, chore something else

fix pushes the patch package version e.g. 1.10.13->1.10.14, feat, the minor: 1.10.13 -> 1.11.0

if you type BREAKING CHANGE somewhere in the commit it'll upgrade the major version 1.10.13->2.0.0

@nstrelow nstrelow force-pushed the dev branch 4 times, most recently from 751b46e to 101671b Compare May 15, 2022 20:44
@nstrelow
Copy link
Contributor

The flutter_form_builder is the problem. It has a lot of dependencies, which are not updated that frequently, which then breaks new flutter versions.

Issue: flutter-form-builder-ecosystem/flutter_form_builder#1021

It is a subdependency: [flutter_chips_input](https://github.com/danvick/flutter_chips_input) by the same author.

Here is a PR fixing it, which has not been merged or published. To use Flutter 3.0.0 with designer, I would then set this as a dependency override. See my other PR.

dependency_overrides:
  flutter_chips_input:
    git: https://github.com/jhaglund/flutter_chips_input.git

@nstrelow
Copy link
Contributor

Aaaand flutter_iconpicker is problematic as well. It has a hardcoded list of all icons, which change with each release and break the whole package each time -.- Very annoying, might be worth to replace at some point.

@johannesvedder johannesvedder added dependencies Pull requests that update a dependency file and removed bug Something isn't working labels May 17, 2022
@johannesvedder
Copy link
Contributor Author

Okay, thanks for the review. We can just close this one when #45 is merged.

@johannesvedder johannesvedder deleted the dev-flutter_3.0 branch July 5, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants