Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Rewrite Pipeline Scheduler based on StateMachine #2749

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Wesley-Jzy
Copy link
Contributor

@Wesley-Jzy Wesley-Jzy commented Feb 16, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

It's not easy to add a new scheduling policy in current Pipeline Scheduler in CAI because of the tightly-coupled design.
This PR plans to use a new design to rewrite Pipeline Schduler to make it more readable and scalable.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Wesley-Jzy Wesley-Jzy force-pushed the feature/simplify_pp_scheduler branch 2 times, most recently from f2866ef to 563f8f7 Compare March 7, 2023 02:06
@Wesley-Jzy Wesley-Jzy force-pushed the feature/simplify_pp_scheduler branch 2 times, most recently from f8c5071 to ab79f4c Compare March 16, 2023 08:15
@Wesley-Jzy Wesley-Jzy force-pushed the feature/simplify_pp_scheduler branch 3 times, most recently from a9b72a5 to dce5707 Compare March 28, 2023 02:38
@Wesley-Jzy Wesley-Jzy force-pushed the feature/simplify_pp_scheduler branch from dce5707 to 9b1eadf Compare April 11, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant