refactor(ext/http): use String.prototype.trim() instead of regex (d…

…enoland#17722)
howqw · Feb 10, 2023 · cf06a7c · cf06a7c
1 parent 68008be
commit cf06a7c
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/ext/http/01_http.js b/ext/http/01_http.js
@@ -51,6 +51,7 @@ const {
  StringPrototypeIncludes,
  StringPrototypeToLowerCase,
  StringPrototypeSplit,
+ StringPrototypeTrim,
  Symbol,
  SymbolAsyncIterator,
  TypeError,
@@ -393,8 +394,9 @@ function upgradeWebSocket(request, options = {}) {
  const upgrade = request.headers.get("upgrade");
  const upgradeHasWebSocketOption = upgrade !== null &&
  ArrayPrototypeSome(
- StringPrototypeSplit(upgrade, /\s*,\s*/),
- (option) => StringPrototypeToLowerCase(option) === "websocket",
+ StringPrototypeSplit(upgrade, ","),
+ (option) =>
+ StringPrototypeToLowerCase(StringPrototypeTrim(option)) === "websocket",
  );
  if (!upgradeHasWebSocketOption) {
  throw new TypeError(
@@ -405,8 +407,9 @@ function upgradeWebSocket(request, options = {}) {
  const connection = request.headers.get("connection");
  const connectionHasUpgradeOption = connection !== null &&
  ArrayPrototypeSome(
- StringPrototypeSplit(connection, /\s*,\s*/),
- (option) => StringPrototypeToLowerCase(option) === "upgrade",
+ StringPrototypeSplit(connection, ","),
+ (option) =>
+ StringPrototypeToLowerCase(StringPrototypeTrim(option)) === "upgrade",
  );
  if (!connectionHasUpgradeOption) {
  throw new TypeError(