Skip to content

Commit

Permalink
chore: disable another flaky Node compat test (denoland#20872)
Browse files Browse the repository at this point in the history
  • Loading branch information
@bartlomieju
bartlomieju committed Oct 10, 2023
1 parent 0606c11 commit 7b80b27
Showing 1 changed file with 136 additions and 120 deletions.
256 changes: 136 additions & 120 deletions cli/tests/node_compat/test/internet/test-dns.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -260,24 +260,26 @@ TEST(async function test_resolveSrv(done) {
checkWrap(req);
});

TEST(function test_resolveSrv_failure(done) {
dnsPromises.resolveSrv(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));

const req = dns.resolveSrv(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveSrv_failure(done) {
// dnsPromises.resolveSrv(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

done();
});
// const req = dns.resolveSrv(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

// assert.strictEqual(result, undefined);

// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });

TEST(async function test_resolvePtr(done) {
function validateResult(result) {
Expand All @@ -300,24 +302,26 @@ TEST(async function test_resolvePtr(done) {
checkWrap(req);
});

TEST(function test_resolvePtr_failure(done) {
dnsPromises.resolvePtr(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolvePtr_failure(done) {
// dnsPromises.resolvePtr(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

const req = dns.resolvePtr(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolvePtr(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);

done();
});
// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });

TEST(async function test_resolveNaptr(done) {
function validateResult(result) {
Expand Down Expand Up @@ -345,24 +349,26 @@ TEST(async function test_resolveNaptr(done) {
checkWrap(req);
});

TEST(function test_resolveNaptr_failure(done) {
dnsPromises.resolveNaptr(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveNaptr_failure(done) {
// dnsPromises.resolveNaptr(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

const req = dns.resolveNaptr(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveNaptr(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);

done();
});
// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });

TEST(async function test_resolveSoa(done) {
function validateResult(result) {
Expand Down Expand Up @@ -394,24 +400,26 @@ TEST(async function test_resolveSoa(done) {
checkWrap(req);
});

TEST(function test_resolveSoa_failure(done) {
dnsPromises.resolveSoa(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveSoa_failure(done) {
// dnsPromises.resolveSoa(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

const req = dns.resolveSoa(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveSoa(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);

done();
});
// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });

TEST(async function test_resolveCaa(done) {
function validateResult(result) {
Expand Down Expand Up @@ -456,24 +464,26 @@ TEST(async function test_resolveCaa(done) {
// checkWrap(req);
// });

TEST(function test_resolveCname_failure(done) {
dnsPromises.resolveCname(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveCname_failure(done) {
// dnsPromises.resolveCname(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

const req = dns.resolveCname(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveCname(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);

done();
});
// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });


TEST(async function test_resolveTxt(done) {
Expand All @@ -494,24 +504,26 @@ TEST(async function test_resolveTxt(done) {
checkWrap(req);
});

TEST(function test_resolveTxt_failure(done) {
dnsPromises.resolveTxt(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveTxt_failure(done) {
// dnsPromises.resolveTxt(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));

const req = dns.resolveTxt(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveTxt(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');

assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);

done();
});
// done();
// });

checkWrap(req);
});
// checkWrap(req);
// });


TEST(function test_lookup_failure(done) {
Expand Down Expand Up @@ -667,48 +679,52 @@ TEST(async function test_lookup_all_mixed(done) {
// });


TEST(function test_lookup_failure(done) {
dnsPromises.lookup(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.expectsError({
code: 'ENOTFOUND',
hostname: addresses.NOT_FOUND
}));

const req = dns.lookup(addresses.NOT_FOUND, (err) => {
assert(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
assert.strictEqual(err.hostname, addresses.NOT_FOUND);
assert.ok(err.message.includes(addresses.NOT_FOUND));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_lookup_failure(done) {
// dnsPromises.lookup(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.expectsError({
// code: 'ENOTFOUND',
// hostname: addresses.NOT_FOUND
// }));

done();
});
// const req = dns.lookup(addresses.NOT_FOUND, (err) => {
// assert(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
// assert.strictEqual(err.hostname, addresses.NOT_FOUND);
// assert.ok(err.message.includes(addresses.NOT_FOUND));

checkWrap(req);
});
// done();
// });

// checkWrap(req);
// });

TEST(function test_resolve_failure(done) {
const req = dns.resolve4(addresses.NOT_FOUND, (err) => {
assert(err instanceof Error);

switch (err.code) {
case 'ENOTFOUND':
case 'ESERVFAIL':
break;
default:
assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
break;
}
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolve_failure(done) {
// const req = dns.resolve4(addresses.NOT_FOUND, (err) => {
// assert(err instanceof Error);

assert.strictEqual(err.hostname, addresses.NOT_FOUND);
assert.ok(err.message.includes(addresses.NOT_FOUND));
// switch (err.code) {
// case 'ENOTFOUND':
// case 'ESERVFAIL':
// break;
// default:
// assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
// break;
// }

done();
});
// assert.strictEqual(err.hostname, addresses.NOT_FOUND);
// assert.ok(err.message.includes(addresses.NOT_FOUND));

checkWrap(req);
});
// done();
// });

// checkWrap(req);
// });


let getaddrinfoCallbackCalled = false;
Expand Down

0 comments on commit 7b80b27

Please sign in to comment.