chore: disable another flaky Node compat test (denoland#20846)

howqw · Oct 9, 2023 · 29026fa · 29026fa
1 parent d868bae
commit 29026fa
Showing 1 changed file with 16 additions and 14 deletions.
diff --git a/cli/tests/node_compat/test/internet/test-dns.js b/cli/tests/node_compat/test/internet/test-dns.js
@@ -214,24 +214,26 @@ TEST(async function test_resolveNs(done) {
  checkWrap(req);
 });
 
-TEST(function test_resolveNs_failure(done) {
- dnsPromises.resolveNs(addresses.NOT_FOUND)
- .then(common.mustNotCall())
- .catch(common.mustCall((err) => {
- assert.strictEqual(err.code, 'ENOTFOUND');
- }));
+// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
+// instead of `ENOTFOUND`.
+// TEST(function test_resolveNs_failure(done) {
+// dnsPromises.resolveNs(addresses.NOT_FOUND)
+// .then(common.mustNotCall())
+// .catch(common.mustCall((err) => {
+// assert.strictEqual(err.code, 'ENOTFOUND');
+// }));
 
- const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) {
- assert.ok(err instanceof Error);
- assert.strictEqual(err.code, 'ENOTFOUND');
+//  const req = dns.resolveNs(addresses.NOT_FOUND, function(err, result) {
+//  assert.ok(err instanceof Error);
+//  assert.strictEqual(err.code, 'ENOTFOUND');
 
- assert.strictEqual(result, undefined);
+//  assert.strictEqual(result, undefined);
 
- done();
- });
+//  done();
+//  });
 
- checkWrap(req);
-});
+//  checkWrap(req);
+// });
 
 TEST(async function test_resolveSrv(done) {
  function validateResult(result) {