Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Removing a watched directory which contains watched file causes an error #24

Closed
jakerr opened this issue Oct 29, 2012 · 1 comment
Closed

Removing a watched directory which contains watched file causes an error #24

jakerr opened this issue Oct 29, 2012 · 1 comment

Comments

@jakerr
Copy link

jakerr commented Oct 29, 2012

I'm on OS X

Removing with "rm -r" a watched dir which includes a watched file causes an error.
I expected rather, that delete events for each item and the containing folder would be generated.

Steps to reproduce

  • Watch a directory
  • Watch a file in the directory
  • Rm -rf the directory

A repro case:

https://gist.github.com/3972447
howeyc added a commit that referenced this issue Nov 1, 2012
@howeyc
BSD - Fix for Issue #24 - Deleting watched directory
b20bf80 
This fixes the issue where the delete of a watched directory sends and
error instead of a delete for the directory and the underlying watched
files.

The reproduce case for reference: https://gist.github.com/3972447

Also included is a test case addition for the above issue.
@howeyc howeyc closed this as completed Nov 3, 2012
@howeyc
Copy link
Owner

howeyc commented Nov 3, 2012

Thanks for the providing the gist, made finding the issue much easier. I hope the fix I put in place works for you on OSX, I only have BSD machines but was able to reproduce the issue.

Please reopen if it doesn't work for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakerr @howeyc