Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Home Page Carrousel #866

Merged

Conversation

Claurt07
Copy link
Contributor

Changed the entire code of the carrousel to improve stability, add autoslide, and change the look.

Changes:

  • Css code to include code for the new Carrousel
  • with 5 slides (intro, project, programs, tech update, and events
  • Homepage HTML with replaced code
  • New JS file with carrousel code
  • Updated home page stats
    other
  • Minor fix in Program page to remove duplicate countries

Screenshots of the change:
image
image

@Claurt07 Claurt07 marked this pull request as ready for review May 30, 2024 03:10
@Claurt07
Copy link
Contributor Author

@kshitijrajsharma this one is a bigger one man -- replaced a bigger chunk of code. Let me know what you think in general.

<p class="stat-title">Total Mappers<sup>&#9432;</sup>
<span class="tooltiptext">Total number of Mappers using <a href="https://tasks.hotosm.org/" target="_blank">HOT Tasking Manager</a> - As of Dec. 2023</span>
<span class="tooltiptext">Total number of Mappers using <a href="https://tasks.hotosm.org/" target="_blank">HOT Tasking Manager</a> - as of May 2024</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still manually update this ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future : ohsomenow provides and API endpoint from which you can query and display the latest numbers

@@ -0,0 +1,67 @@
document.addEventListener('DOMContentLoaded', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have source for it ? or its a plain code you have written ? if there is a source : You should mention it in top of the page !

@kshitijrajsharma
Copy link
Member

Changes looks good to me , Merging the PR . You can address the comments later ( not that they are much specific haha )

@kshitijrajsharma kshitijrajsharma merged commit 695bce2 into hotosm:gh-pages Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants