Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Program Page Feature Image code #853

Closed
wants to merge 2 commits into from

Conversation

Claurt07
Copy link
Contributor

Changes:

  • The image could not be changed through Siteleaf so I changed the code --Previously the image was on the CSS file.

@Claurt07
Copy link
Contributor Author

@kshitijrajsharma Just a quick fix for the image section on the Program page :)

@@ -5894,6 +5918,178 @@ th, td {

}

.half-block-tools {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended css ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, Although I havent committed the related HTML yet

@kshitijrajsharma
Copy link
Member

Its good practice to include changes that are related to that fix only . There is one .md change and basecss which doesn't belong to this fix

If you want to include extra changes in PR then you can mention them in description.

You can keep working on other things for same file , You just need to branchout with base from this PR branch

Its okay for now, tips for next changes 😉

@Claurt07 Claurt07 closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants