Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix news section in country pages#483 #484

Conversation

Muskan284
Copy link
Contributor

@ramyaragupathy kindly review .
also can u suggest other issues to work upon.
fixes #483
Screenshot from 2019-03-21 12-20-37

@uwaiszaki
Copy link
Contributor

@ramyaragupathy 67d8d59 was merged for #421 which changed author.html for project page but this is not showing those changes in it.

@Muskan284
Copy link
Contributor Author

@ramyaragupathy kindly review this pr.

Copy link
Member

@ramyaragupathy ramyaragupathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muskan284 - Thanks for spotting and working on this issue.

As highlighted in your issue there are two - separators in the news section. Your fix should retain just one separator. However I don't see any separators appearing now between author name and Date.

image

@ramyaragupathy
Copy link
Member

Stale - will fix this in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix news section in where we work page
3 participants