Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Docs and Guidelines #399

Merged
merged 28 commits into from
Jan 29, 2019
Merged

[wip] Docs and Guidelines #399

merged 28 commits into from
Jan 29, 2019

Conversation

arunasank
Copy link
Contributor

@arunasank arunasank commented Jan 18, 2019

Fixes #398 and #386 when done.

Current Look

screen shot 2019-01-18 at 6 47 36 pm

Things done

  • Create markdown pages for the wiki content, after organising this content into sub-sections
  • Placement for the docs page - this is going to be part of the footer
  • Redesign the footer to be more balanced
  • Bring more visibility to the media toolkit and to the organizational bylaws and articles of incorporation

TODO

  • Design a layout for the docs page, and make decisions around including the markdown content here.
  • Include Github in the list of social media links
  • Remove Media Toolkit from the contact page, or modify its presence there, to reflect the new changes.

cc/ @hotosm/tech

@arunasank arunasank changed the title Docs and Guidelines [wip] Docs and Guidelines Jan 18, 2019
@arunasank
Copy link
Contributor Author

The GitHub SVG logo is from https://github.com/GoogleChrome/browser-bug-search/blob/master/img/octocat.svg. @willemarcel found this by looking for GitHub-Mark-Light (The name is from the GitHub resources for the logo). Would be nice to get a sense for how we generally do this for other icons.

@arunasank
Copy link
Contributor Author

Docs landing page

screen shot 2019-01-25 at 6 27 03 pm


An example docs page

screen shot 2019-01-25 at 6 27 20 pm


Thanks for pairing with me to get the kinks sorted in these pages @smit1678.

  • The individual docs pages now follow the layout of the page.html layout file.
  • The docs landing page follows the layout of the groups.html layout file.
  • We have a link to the #hotosm-website slack channel on each docs page.

@smit1678 @ramyaragupathy can one of you review this for me?

Some things I am specifically concerned about:

  • The sizes of the colour tiles in the colours-fonts-logo page.

@ramyaragupathy
Copy link
Member

Awesome 🎉 - added in style changes that worked for the logo file @arunasank. Other items that I feel could be modified:

Adjusting logos in the footer with the text height

image

Adding slack links in the sidebar text

image

@arunasank
Copy link
Contributor Author

Thanks for reviewing @ramyaragupathy. ♥️

Adding slack links in the sidebar text

The support button leads to the slack channel. Can you clarify what you mean here?

@ramyaragupathy

@ramyaragupathy
Copy link
Member

Didn't check the support button link to Slack @arunasank. That should work great.

@arunasank
Copy link
Contributor Author

I'll reword that button text @ramyaragupathy. Thanks for the tip!

@smit1678
Copy link
Contributor

@arunasank Awesome work. I made a couple changes to rearrange the post order, renamed some titles, and added some text.

@smit1678
Copy link
Contributor

👍 Last review looks good. Made a quick adjustment to the footer to separate the Bylaws and Articles of Incorporation to be two lines which looks better. And then moved the social icons over to give more space to the footer to keep and keep in line with the original design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants