Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeople #388

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Repeople #388

merged 3 commits into from
Jan 16, 2019

Conversation

arunasank
Copy link
Contributor

Fixes #254 when done.

Two issues remain

I am new to Jekyll, and trying to fix the following. Let me know if any of you have thoughts
@hotosm/tech-staff

  • Currently, I see that the staff page looks ok, however the _layouts/roster.html is not even called when the Voting Members and Board Members link is selected. Investigating what I need to change to fix this.
screen shot 2019-01-04 at 3 44 06 pm screen shot 2019-01-04 at 3 44 16 pm

  • Secondly, the people pages for individuals is messed up for everyone except voting members. Investigating why, and what fixes need to happen here.
screen shot 2019-01-04 at 3 44 42 pm

@ramyaragupathy
Copy link
Member

ramyaragupathy commented Jan 7, 2019

@arunasank - when there is a collection/folder present with the same name as markdown file, the collection seems to get the precedence. So in our case markdown file is not invoked for voting-members/ path. Markdown file has the reference to the roster. So instead of getting the roster layout just the folder contents are displayed. I tried moving this as a subfolder under people and the markdown gets invoked. People list is empty because we're not handling this in the roster file yet.

image

@arunasank
Copy link
Contributor Author

@ramyaragupathy Thanks for investigating! This clarifies a lot of things to me. 🙇‍♀️ I will make the fixes.

@ramyaragupathy and others on @hotosm/tech are there resources you like using for Jekyll advanced usage?

@smit1678
Copy link
Contributor

smit1678 commented Jan 7, 2019

@ramyaragupathy and others on @hotosm/tech are there resources you like using for Jekyll advanced usage?

@arunasank For the Liquid templating, this is a good resource: https://shopify.github.io/liquid/. For overall Jekyll layouts, etc: https://learn.cloudcannon.com/

@ramyaragupathy
Copy link
Member

Usually refer to:

@arunasank
Copy link
Contributor Author

We are currently trying to figure out if we can use sub-collections on Jekyll. If yes, this would be the preferred approach.

If we cannot figure out sub-collections, we can decide between

  • Renaming all the pages to be staff-*, vote-* or board-* or staff-board-* etc, and keeping them all aggregated like they are right now. If we go down this route we would have to modify the permalinks to the pages per conversation with @smit1678 and @ramyaragupathy.
  • Grouping files in separate collections, as done on this PR, but if we go down this path, we need to figure out ways to de-duplicate files about members who belong to two different groups. For example, someone who is a voting member and a staff.

@arunasank
Copy link
Contributor Author

Thanks @smit1678 for simplifying this entire fix, and @ramyaragupathy for helping debug. 🙏

I have moved the files to their sub-collections, after @smit1678's fix to config.yml.

@arunasank
Copy link
Contributor Author

I built the website locally, and things look good!

screen shot 2019-01-14 at 4 35 38 pm

screen shot 2019-01-14 at 4 35 52 pm

screen shot 2019-01-14 at 4 36 02 pm

Amelia Hunt - archived, is not clickable from a blog post

screen shot 2019-01-14 at 4 39 21 pm

@arunasank arunasank changed the title [WIP] Repeople Repeople Jan 16, 2019
@smit1678
Copy link
Contributor

Nice work @arunasank! 👏 👍 🎉

Did a quick review and everything looks good.

@smit1678 smit1678 merged commit a9f0409 into gh-pages Jan 16, 2019
@smit1678 smit1678 deleted the repeople branch January 16, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize people listing within repo/Siteleaf
3 participants