Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add countries #158

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Add countries #158

merged 2 commits into from
Mar 20, 2018

Conversation

dakotabenjamin
Copy link
Member

This adds a bunch of countries and territories. I definitely would like some feedback because there can be implications to the choices of names of some of these countries. In that regard I tweaked the way countries are handled in the people pages. I made a list of possible names that could be used and if the user creating their page adds a country in that list then it uses that country. For example:

---
title: United States
continent: NA
urlname: united-states
names:
  - United States
  - United States of America
  - US
  - USA
---

There are some drawbacks to this, however. A person who uses USA in their profile will still link to a page called United States. Do you think there's a better way to handle this?

I used a table from the Drupal db whose source I am unsure of. It looks like this:
image

I added some extra items to a few countries 'names' tag:

  • Palestine
  • Macao
  • Hong Kong
  • Myanmar (Burma)

And I changed the following titles for clarity:
Congo (Brazzaville) ➡️ Republic of the Congo
Congo (Kinshasa) ➡️ Democratic Republic of the Congo

@smit1678
Copy link
Contributor

@dakotabenjamin 👍 Sounds good, I think this approach makes sense. I think we an lock down what countries are able to be selected from via Siteleaf but a quick loop on possible names seems fine.

For naming, as I mentioned in Slack, I think we just use the convention that is used within OSM. But for things like Congo (Brazzaville) to Republic of Congo that's fine.

Does this PR supersede #157?

@smit1678 smit1678 merged commit 7352e52 into hotosm:gh-pages Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants