Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/19 json oas compat #20

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Issue/19 json oas compat #20

merged 5 commits into from
Dec 18, 2020

Conversation

hotmeteor
Copy link
Owner

@hotmeteor hotmeteor commented Dec 11, 2020 •
edited

Changes

Adds support for 3.0.x nullable property by forcing an array of types that includes 'null'

Doesn't apply to 3.1.x specs since nullable will be deprecated

See https://apisyouwonthate.com/blog/openapi-v31-and-json-schema-2019-09

Resolves #19

Fixes

  • Fixes bad detection and reporting of invalid paths. Invalid paths will throw a correct request error now.
  • Fixes bad detection and reporting of missing specs. Missing specs will throw a correct request error now.
  • Refactors ResponseValidator to be more readable

@hotmeteor hotmeteor merged commit 3d483ce into master Dec 18, 2020
@hotmeteor hotmeteor deleted the issue/19-json-oas-compat branch December 18, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility between JSON Schema validation & OpenAPI specification
1 participant
@hotmeteor