detect MPICH via HYDRA
#3984
Merged
detect MPICH via HYDRA
#3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix horovod#2761. Horovod still uses `MPICH` in `mpirun --version` to detect MPICH. In the unittest, the test case has `MPICHLIB_CFLAGS` flag. However, not all MPICH builds has this flag. For example, on Ubuntu 22.04, the MPICH installed with `apt-get` has no `MPICH`. Here is the way to reproduce it: ```docker FROM ubuntu:22.04 RUN apt-get update && apt-install -y mpich && mpirun --version ``` The output is: ``` HYDRA build details: Version: 4.0 Release Date: Fri Jan 21 10:42:29 CST 2022 CC: gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/build/mpich-0xgrG5/mpich-4.0=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z,relro Configure options: '--with-hwloc-prefix=/usr' '--with-device=ch4:ofi' 'FFLAGS=-O2 -ffile-prefix-map=/build/mpich-0xgrG5/mpich-4.0=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -fallow-invalid-boz -fallow-argument-mismatch' '--prefix=/usr' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/mpich-0xgrG5/mpich-4.0=. -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security' 'LDFLAGS=-Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z,relro' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' Process Manager: pmi Launchers available: ssh rsh fork slurm ll lsf sge manual persist Topology libraries available: hwloc Resource management kernels available: user slurm ll lsf sge pbs cobalt Demux engines available: poll select ``` Using `HYDRA` is safe, as it is hard-coded in the MPICH source code: https://github.com/pmodels/mpich/blob/673b348edf97753502438d6aa9030dcf76074177/src/pm/hydra/mpiexec/options.c#L1154 Signed-off-by: Jinzhe Zeng <[email protected]>
maxhgerlach
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
Fixes #2761.
Horovod still uses
MPICHinmpirun --versionto detect MPICH. In the unittest, the test case hasMPICHLIB_CFLAGSflag. However, not all MPICH builds has this flag. For example, on Ubuntu 22.04, the MPICH installed withapt-gethas noMPICH.Here is the way to reproduce it (using docker):
The output is:
Using
HYDRAis safe, as it is hard-coded in the MPICH source code: https://github.com/pmodels/mpich/blob/673b348edf97753502438d6aa9030dcf76074177/src/pm/hydra/mpiexec/options.c#L1154Review process to land