Fix incorrect segmentation for non-ASCII characters #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix formatting and catching up with `Rpc-h:main`
nionis
approved these changes
May 2, 2023
diegoalzate
approved these changes
May 2, 2023
nionis
added a commit
that referenced
this pull request
Jun 9, 2023
nionis
pushed a commit
that referenced
this pull request
Jun 12, 2023
Co-authored-by: Robert Kiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated @robertkiel PR
Changes the segmentation code to respect UTF-8 character boundaries
Current situation
splitUtf8Stringsalters strings whenever there is a non-ASCII character atmaxBytes, such that joining the chunks leads to a different string.New behavior
Respect characters with encoded length > 1 and split string accordingly