Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to dp and fs #263

Merged
merged 18 commits into from
Apr 4, 2023
Merged

Add metrics to dp and fs #263

merged 18 commits into from
Apr 4, 2023

Conversation

diegoalzate
Copy link
Contributor

@diegoalzate diegoalzate commented Mar 3, 2023 •
edited

Related to #281

Weird things in this pr

Metrics that were added

Discovery platform

Prometheus Pull model: open a port that will receive metrics

what will we track?

  • successful requests
  • failed requests
  • request duration

Funding service

Prometheus Pull model: open a port that will receive metrics

what will we track?

  • successful requests
  • failed requests
  • request duration
  • successful funding reqs
  • failed funding reqs

@diegoalzate diegoalzate self-assigned this Mar 3, 2023
@diegoalzate diegoalzate added the enhancement New feature or request label Mar 28, 2023
@diegoalzate diegoalzate marked this pull request as ready for review March 31, 2023 16:36
@diegoalzate diegoalzate requested a review from a team March 31, 2023 16:36
nionis
nionis suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@nionis nionis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small naming change suggestion to improve readability.
Question: once we start collecting logs, is there a way to distinguish the various instances of DP / FS we are running? maybe we need to include the pkg version somewhere?

apps/funding-service/src/entry-server/middleware/index.ts Outdated Show resolved Hide resolved
@diegoalzate diegoalzate requested a review from nionis April 4, 2023 14:22
@diegoalzate diegoalzate merged commit 7ca6c26 into main Apr 4, 2023
@diegoalzate diegoalzate deleted the add-metrics-to-dp-and-fs branch April 4, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitilge sitilge sitilge left review comments

@nionis nionis nionis approved these changes

Assignees

@diegoalzate diegoalzate

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diegoalzate @nionis @sitilge